Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: declare com.coveo:fmt-maven-plugin version/configuration #90

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Jan 21, 2020

We should explicitly declare the formatter plugin version/options.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020
@chingor13 chingor13 requested a review from a team January 22, 2020 16:30
@chingor13 chingor13 merged commit 5cf71a6 into googleapis:master Jan 27, 2020
@chingor13 chingor13 deleted the coveo branch January 27, 2020 18:47
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 7, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.5.0](https://github.com/googleapis/java-shared-config/compare/v0.4.0...v0.5.0) (2020-04-07)


### Features

* add ban duplicate classes rule ([#126](https://github.com/googleapis/java-shared-config/issues/126)) ([e38a7cc](https://github.com/googleapis/java-shared-config/commit/e38a7cc949396f8f5696e62cd060e0c076047b8d))
* add devsite javadoc profile ([#121](https://github.com/googleapis/java-shared-config/issues/121)) ([7f452fb](https://github.com/googleapis/java-shared-config/commit/7f452fb6c5704f6ce0f731085479a28fb99ebcb9))
* add maven flatten plugin ([#127](https://github.com/googleapis/java-shared-config/issues/127)) ([fb00799](https://github.com/googleapis/java-shared-config/commit/fb00799c416d324d68da5b660a26f7ef595c26d9))


### Bug Fixes

* declare com.coveo:fmt-maven-plugin version/configuration ([#90](https://github.com/googleapis/java-shared-config/issues/90)) ([5cf71a6](https://github.com/googleapis/java-shared-config/commit/5cf71a6ed699907082756e70c2fdee6ad3632f38))


### Dependencies

* update dependency com.google.cloud.samples:shared-configuration to v1.0.13 ([#118](https://github.com/googleapis/java-shared-config/issues/118)) ([58ae69e](https://github.com/googleapis/java-shared-config/commit/58ae69eb5ba037963cdaed0c2b0e30663bc873eb))
* update dependency com.puppycrawl.tools:checkstyle to v8.29 ([f62292d](https://github.com/googleapis/java-shared-config/commit/f62292dab75699a75f8a7d499fe2ccfb7ee93783))
* update dependency org.apache.maven.plugins:maven-antrun-plugin to v1.8 ([#124](https://github.com/googleapis/java-shared-config/issues/124)) ([a681536](https://github.com/googleapis/java-shared-config/commit/a68153643400c3f3b5c5959cda4dc3b552336427))
* update dependency org.apache.maven.plugins:maven-dependency-plugin to v3.1.2 ([#107](https://github.com/googleapis/java-shared-config/issues/107)) ([c9b096b](https://github.com/googleapis/java-shared-config/commit/c9b096b81b1f4f8dc2d1302f259f0321722e1ca5))
* update dependency org.apache.maven.plugins:maven-site-plugin to v3.9.0 ([#103](https://github.com/googleapis/java-shared-config/issues/103)) ([abe7140](https://github.com/googleapis/java-shared-config/commit/abe714060e858c70a83888fb34438c45d97b1168))
* update dependency org.codehaus.mojo:build-helper-maven-plugin to v3.1.0 ([#101](https://github.com/googleapis/java-shared-config/issues/101)) ([ac69572](https://github.com/googleapis/java-shared-config/commit/ac69572be76e4462fdf65fa6e7f0935c3d51d827))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
BenWhitehead added a commit to danielduhh/java-storage that referenced this pull request May 26, 2021
fmt-maven-plugin v2.10 is compiled for java 11, v2.9 is compiled for java 8

port of fix from googleapis/java-shared-config#90
danielduhh added a commit to googleapis/java-storage that referenced this pull request Jun 10, 2021
* build: add kokoro & ci changes

* add samples folder to pass ci

* build: pin fmt-maven-plugin version to 2.9

fmt-maven-plugin v2.10 is compiled for java 11, v2.9 is compiled for java 8

port of fix from googleapis/java-shared-config#90

* remove samples directory & ci

* add ci block

* remove snippet bot config

* sync ci changes

* fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759)

Port of googleapis/google-cloud-go#3806

Fixes #755

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants