removed callbacks

Author: vijay-qlogic

samples/document-snippets/row.js

@@ -17,7 +17,7 @@ const Bigtable = require('@google-cloud/bigtable');
 const bigtable = new Bigtable();
 
 const snippets = {
-  createRow: (instanceId, tableId, callback) => {
+  createRow: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -33,11 +33,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_create_row]
-
-    callback();
   },
 
-  createRules: (instanceId, tableId, callback) => {
+  createRules: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -75,11 +73,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_create_rules]
-
-    callback();
   },
 
-  deleteAllCells: (instanceId, tableId, callback) => {
+  deleteAllCells: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -94,11 +90,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_delete_all_cells]
-
-    callback();
   },
 
-  deleteCells: (instanceId, tableId, callback) => {
+  deleteCells: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -122,11 +116,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_delete_particular_cells]
-
-    callback();
   },
 
-  exists: (instanceId, tableId, callback) => {
+  exists: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -142,11 +134,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_row_exists]
-
-    callback();
   },
 
-  filter: (instanceId, tableId, callback) => {
+  filter: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -189,11 +179,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_row_filter]
-
-    callback();
   },
 
-  get: (instanceId, tableId, callback) => {
+  get: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -226,11 +214,9 @@ const snippets = {
     //   });
 
     // [END bigtable_get_row]
-
-    callback();
   },
 
-  getMetadata: (instanceId, tableId, callback) => {
+  getMetadata: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -247,11 +233,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_get_row_meta]
-
-    callback();
   },
 
-  increment: (instanceId, tableId, callback) => {
+  increment: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -283,11 +267,9 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_row_increment]
-
-    callback();
   },
 
-  save: (instanceId, tableId, callback) => {
+  save: (instanceId, tableId) => {
     const instance = bigtable.instance(instanceId);
     const table = instance.table(tableId);
 
@@ -307,8 +289,6 @@ const snippets = {
         // Handle the error.
       });
     // [END bigtable_row_save]
-
-    callback();
   },
 };
 

samples/document-snippets/tests/row.js

@@ -24,7 +24,6 @@ const bigtable = new Bigtable();
 const INSTANCE_ID = `nodejs-bigtable-samples-${uuid.v4()}`.substr(0, 30); // Bigtable naming rules
 const CLUSTER_ID = `nodejs-bigtable-samples-${uuid.v4()}`.substr(0, 30); // Bigtable naming rules
 const TABLE_ID = `nodejs-bigtable-samples-${uuid.v4()}`.substr(0, 30); // Bigtable naming rules
-// const FAMILY_ID = `sample-family-${uuid.v4()}`.substr(0, 10); // Bigtable naming rules
 
 const rowSnippets = require('../row.js');
 
@@ -49,31 +48,31 @@ describe('Row Snippets', function() {
     await instance.delete();
   });
 
-  it('should create a row', done => {
-    rowSnippets.createRow(INSTANCE_ID, TABLE_ID, done);
+  it('should create a row', () => {
+    rowSnippets.createRow(INSTANCE_ID, TABLE_ID);
   });
-  it('should create a row rules', done => {
-    rowSnippets.createRules(INSTANCE_ID, TABLE_ID, done);
+  it('should create a row rules', () => {
+    rowSnippets.createRules(INSTANCE_ID, TABLE_ID);
   });
-  it('should delete all cells', done => {
-    rowSnippets.deleteAllCells(INSTANCE_ID, TABLE_ID, done);
+  it('should delete all cells', () => {
+    rowSnippets.deleteAllCells(INSTANCE_ID, TABLE_ID);
   });
-  it('should delete selected cells', done => {
-    rowSnippets.deleteCells(INSTANCE_ID, TABLE_ID, done);
+  it('should delete selected cells', () => {
+    rowSnippets.deleteCells(INSTANCE_ID, TABLE_ID);
   });
-  it('should check row exists', done => {
-    rowSnippets.exists(INSTANCE_ID, TABLE_ID, done);
+  it('should check row exists', () => {
+    rowSnippets.exists(INSTANCE_ID, TABLE_ID);
   });
-  it('should mutate row with matched filter', done => {
-    rowSnippets.filter(INSTANCE_ID, TABLE_ID, done);
+  it('should mutate row with matched filter', () => {
+    rowSnippets.filter(INSTANCE_ID, TABLE_ID);
   });
-  it('should get row meta-data', done => {
-    rowSnippets.getMetadata(INSTANCE_ID, TABLE_ID, done);
+  it('should get row meta-data', () => {
+    rowSnippets.getMetadata(INSTANCE_ID, TABLE_ID);
   });
-  it('should increment row', done => {
-    rowSnippets.increment(INSTANCE_ID, TABLE_ID, done);
+  it('should increment row', () => {
+    rowSnippets.increment(INSTANCE_ID, TABLE_ID);
   });
-  it('should save row', done => {
-    rowSnippets.save(INSTANCE_ID, TABLE_ID, done);
+  it('should save row', () => {
+    rowSnippets.save(INSTANCE_ID, TABLE_ID);
   });
 });