File tree 1 file changed +3
-0
lines changed
1 file changed +3
-0
lines changed Original file line number Diff line number Diff line change @@ -1502,6 +1502,7 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
1502
1502
const onBatchResponse = (
1503
1503
err : ServiceError | PartialFailureError | null
1504
1504
) => {
1505
+ // TODO: enable retries when the entire RPC fails
1505
1506
if ( err ) {
1506
1507
// The error happened before a request was even made, don't retry.
1507
1508
callback ( err ) ;
@@ -1546,6 +1547,8 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
1546
1547
retryOpts,
1547
1548
} )
1548
1549
. on ( 'error' , ( err : ServiceError ) => {
1550
+ // TODO: this check doesn't actually do anything, onBatchResponse
1551
+ // currently doesn't retry RPC errors, only entry failures
1549
1552
if ( numRequestsMade === 0 ) {
1550
1553
callback ( err ) ; // Likely a "projectId not detected" error.
1551
1554
return ;
You can’t perform that action at this time.
0 commit comments