Skip to content

Commit f850765

Browse files
committedJan 12, 2022
add todos
1 parent a1b4d42 commit f850765

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed
 

‎src/table.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1502,6 +1502,7 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
15021502
const onBatchResponse = (
15031503
err: ServiceError | PartialFailureError | null
15041504
) => {
1505+
// TODO: enable retries when the entire RPC fails
15051506
if (err) {
15061507
// The error happened before a request was even made, don't retry.
15071508
callback(err);
@@ -1546,6 +1547,8 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
15461547
retryOpts,
15471548
})
15481549
.on('error', (err: ServiceError) => {
1550+
// TODO: this check doesn't actually do anything, onBatchResponse
1551+
// currently doesn't retry RPC errors, only entry failures
15491552
if (numRequestsMade === 0) {
15501553
callback(err); // Likely a "projectId not detected" error.
15511554
return;

0 commit comments

Comments
 (0)