Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add npm run compile to the testproxy command #1258

Conversation

danieljbruce
Copy link
Contributor

The test proxy references the compiled client library code. Every time the test proxy is run, we want it to reflect the source code so that as we develop we don’t get confused about what gets observed.

Fixes #1253 🦕

The test proxy references the compiled client library code. Every time the test proxy is run, we want it to reflect the source code so that as we develop we don’t get confused about what gets observed.
@danieljbruce danieljbruce requested review from a team as code owners March 15, 2023 14:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Mar 15, 2023
@danieljbruce danieljbruce changed the title Add npm run compile to the testproxy command feat: Add npm run compile to the testproxy command Mar 15, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2023
@danieljbruce danieljbruce merged commit 52c06a2 into googleapis:main Mar 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding npm run compile to run every time the test proxy is run to make development easier
2 participants