Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: migrate to new proto annotations #604

Merged
merged 5 commits into from
Jan 28, 2020
Merged

fix: migrate to new proto annotations #604

merged 5 commits into from
Jan 28, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:

Log from Synthtool 
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:5599b61e56a372d21b671969ee915fbca0f6c3a0daaeb898d01f8f685f1bbc8b
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/bigtable/artman_bigtable.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/bigtable-v2.
synthtool > Running generator for google/bigtable/admin/artman_bigtableadmin.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/bigtable-admin-v2.
synthtool > Replaced '../../package.json' in src/v2/bigtable_client.js.
synthtool > Replaced '../../package.json' in src/v2/bigtable_instance_admin_client.js.
synthtool > Replaced '../../package.json' in src/v2/bigtable_table_admin_client.js.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
npm WARN npm npm does not support Node.js v12.14.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

> core-js@2.6.11 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"


> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/bigtable@2.3.1 prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile

npm WARN npm npm does not support Node.js v12.14.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/bigtable@2.3.1 compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r src/v2 build/src/ && cp -r proto* build/ && cp test/*.js build/test

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 723 packages from 1312 contributors and audited 2035 packages in 20.192s
found 0 vulnerabilities

npm WARN npm npm does not support Node.js v12.14.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/bigtable@2.3.1 fix /tmpfs/src/git/autosynth/working_repo
> gts fix && npm run lintfix

npm WARN npm npm does not support Node.js v12.14.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/bigtable@2.3.1 lintfix /tmpfs/src/git/autosynth/working_repo
> eslint --fix '**/*.js'


/tmpfs/src/git/autosynth/working_repo/samples/document-snippets/app-profile.js
   18:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   41:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   59:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   77:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   96:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  115:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/document-snippets/cluster.js
   18:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   38:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   56:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   74:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   93:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  112:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/document-snippets/family.js
   18:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   37:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   55:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   74:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   93:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  118:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/document-snippets/instance.js
   18:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   63:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   91:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  115:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  157:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  174:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  192:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  209:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  226:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  252:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  270:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  287:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  304:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  330:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  351:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/document-snippets/row.js
   17:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   37:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   79:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
   98:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  126:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  146:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  193:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  230:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  251:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  287:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/document-snippets/table.js
   15:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  300:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  318:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require
  345:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/filterSnippets.js
  40:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/hello-world/index.js
  14:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/instances.js
  18:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/quickstart.js
  27:28  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/readSnippets.js
  29:30  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/tableadmin.js
  16:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/app-profile.js
  19:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/cluster.js
  19:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/family.js
  19:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/filters.js
  18:26  error  "snap-shot-it" is not found            node/no-missing-require
  19:26  error  "chai" is not found                    node/no-missing-require
  22:28  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/instance.js
  19:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/instances.test.js
  17:26  error  "chai" is not found                    node/no-missing-require
  21:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/reads.js
  18:26  error  "snap-shot-it" is not found            node/no-missing-require
  21:28  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/row.js
  19:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/table.js
  19:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/write.js
  17:26  error  "chai" is not found                    node/no-missing-require
  20:26  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/writeBatch.js
  28:28  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/writeConditionally.js
  28:28  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/writeIncrement.js
  28:28  error  "@google-cloud/bigtable" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/writeSimple.js
  24:28  error  "@google-cloud/bigtable" is not found  node/no-missing-require

✖ 72 problems (72 errors, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/bigtable@2.3.1 lintfix: `eslint --fix '**/*.js'`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/bigtable@2.3.1 lintfix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-01-25T12_10_08_273Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/bigtable@2.3.1 fix: `gts fix && npm run lintfix`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/bigtable@2.3.1 fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-01-25T12_10_08_284Z-debug.log
installing semver@^5.5.0
installing minimist@^1.2.0
installing uglify-js@^3.3.25
installing espree@^3.5.4
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2020
@bcoe bcoe changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. build: migrate to new proto annotations Jan 27, 2020
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020 •
edited
Loading

Codecov Report

Merging #604 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   73.06%   73.06%           
=======================================
  Files          33       33           
  Lines       15929    15929           
  Branches      528      528           
=======================================
  Hits        11639    11639           
  Misses       4289     4289           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a513aff...ef3c826. Read the comment docs.

@alexander-fenster alexander-fenster self-assigned this Jan 28, 2020
@alexander-fenster
Copy link
Contributor

I need to figure out what's going wrong here.

alexander-fenster
alexander-fenster approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works - finally!

@alexander-fenster alexander-fenster changed the title build: migrate to new proto annotations fix: migrate to new proto annotations Jan 28, 2020
@alexander-fenster alexander-fenster merged commit e095c5a into master Jan 28, 2020
@alexander-fenster alexander-fenster deleted the autosynth branch January 28, 2020 07:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees

@alexander-fenster alexander-fenster

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoshi-automation @alexander-fenster @bcoe @googlebot @kokoro-team