Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: improve types for instance #655

Merged
merged 1 commit into from
Mar 19, 2020
Merged

fix: improve types for instance #655

merged 1 commit into from
Mar 19, 2020

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Mar 19, 2020

One more PR left, then we'll have all the files in src/ done.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #655 into master will increase coverage by 0.04%.
The diff coverage is 99.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   96.38%   96.42%   +0.04%     
==========================================
  Files          15       15              
  Lines       13118    13296     +178     
  Branches      810      822      +12     
==========================================
+ Hits        12644    12821     +177     
- Misses        471      472       +1     
  Partials        3        3
Impacted Files Coverage Δ
src/table.ts 99.83% <100%> (ø) ⬆️
src/app-profile.ts 99.59% <100%> (ø) ⬆️
src/row.ts 100% <100%> (ø) ⬆️
src/cluster.ts 99.35% <100%> (ø) ⬆️
src/instance.ts 99.82% <99.22%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54830f...351df16. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants