Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add gapic getAppProfilesStream method #771

Merged
merged 4 commits into from
Jul 28, 2020
Merged

feat: add gapic getAppProfilesStream method #771

merged 4 commits into from
Jul 28, 2020

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Jul 20, 2020 •
edited
Loading

Adding streaming methods for getInstances, getClusters, getAppProfiles to mimic gapic client

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

blocked by #762

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2020
@AVaksman AVaksman added status: blocked Resolving the issue is dependent on other work. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 20, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2020
@google-cla
Copy link

google-cla bot commented Jul 20, 2020

☹️ Sorry, but only Googlers may change the label cla: yes.

@AVaksman AVaksman changed the title feat: add gapic streaming method feat: add gapic streaming methods Jul 20, 2020
@codecov
Copy link

codecov bot commented Jul 20, 2020 •
edited
Loading

Codecov Report

Merging #771 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          17       17           
  Lines       15818    15880   +62     
  Branches      955      892   -63     
=======================================
+ Hits        15682    15744   +62     
  Misses        133      133           
  Partials        3        3
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/instance.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2a74e...a37f3f2. Read the comment docs.

@AVaksman AVaksman force-pushed the add_gapic_streams branch from cddd1ef to dcd98be Compare July 22, 2020 03:52
@AVaksman AVaksman force-pushed the add_gapic_streams branch from dcd98be to 80c2489 Compare July 27, 2020 18:15
@AVaksman AVaksman marked this pull request as ready for review July 27, 2020 18:16
@AVaksman AVaksman requested a review from a team as a code owner July 27, 2020 18:16
@AVaksman AVaksman removed the status: blocked Resolving the issue is dependent on other work. label Jul 28, 2020
@AVaksman AVaksman changed the title feat: add gapic streaming methods feat: add gapic getAppProfilesStream method Jul 28, 2020
@AVaksman AVaksman merged commit c694ae5 into googleapis:master Jul 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stephenplusplus stephenplusplus

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AVaksman @stephenplusplus