feat: getAppProfilesStream emits (if there are any failed locations present) decorated error with failedLocations info #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AVaksman
commented
Sep 3, 2020
AVaksman
commented
- Ensure the tests and linter pass
- Code coverage does not decrease (if any source code was changed)
- Appropriate docs were updated (if necessary)
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 17 17
Lines 15947 15974 +27
Branches 898 966 +68
=======================================
+ Hits 15811 15838 +27
Misses 133 133
Partials 3 3
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: bigtable
stephenplusplus
approved these changes
Sep 3, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.