Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove common protos #853

Merged
merged 1 commit into from
Mar 18, 2021
Merged

fix: remove common protos #853

merged 1 commit into from
Mar 18, 2021

Conversation

alexander-fenster
Copy link
Contributor

Common protos do not belong here, they are a part of google-gax.

Common protos do not belong here, they are a part of google-gax.
@alexander-fenster alexander-fenster requested review from a team as code owners March 17, 2021 19:50
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Mar 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #853 (c89dcc7) into master (c7d202b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          18       18           
  Lines       17424    17424           
  Branches     1025      952   -73     
=======================================
  Hits        17289    17289           
  Misses        132      132           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d202b...c89dcc7. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kind of curious .... how did these end up here?

@JustinBeckwith
Copy link
Contributor

ok woah this was a pre-gax thing

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants