chore!: migrate to Node 18 #2271

alkatrivedi · 2025-04-01T08:47:31Z

No description provided.

generated-files-bot · 2025-04-01T08:47:39Z

Warning: This pull request is touching the following templated files:

.kokoro/continuous/node14/common.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/continuous/node14/lint.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/continuous/node14/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/continuous/node14/system-test.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/continuous/node14/test.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/presubmit/node14/common.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/presubmit/node14/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/presubmit/node14/system-test.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/presubmit/node14/test.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/presubmit/node18/system-test-multiplexed-session.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
.github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…dejs-spanner into migrate-to-node-18

surbhigarg92 · 2025-04-16T08:23:31Z

src/transaction.ts

      )
        ?.on('response', response => {
          if (response.metadata && response.metadata!.transaction && !this.id) {
            this._update(response.metadata!.transaction);
          }
        })
-        .on('error', err => {
+        .on('error', async err => {


This is problematic. If you make "error" event handler async , then span might not get end properly. Remove async from here and do void this.begin()

surbhigarg92 · 2025-04-16T08:23:44Z

src/transaction.ts

      )
        .on('response', response => {
          if (response.metadata && response.metadata!.transaction && !this.id) {
            this._update(response.metadata!.transaction);
          }
        })
-        .on('error', err => {
+        .on('error', async err => {


surbhigarg92 · 2025-04-16T08:26:28Z

src/session-pool.ts

@@ -768,7 +771,9 @@ export class SessionPool extends EventEmitter implements SessionPoolInterface {
      const index = this._inventory.sessions.indexOf(session);

      this._inventory.sessions.splice(index, 1);
-      this._destroy(session);
+      this._destroy(session)


could we use void here instead ?

surbhigarg92 · 2025-04-16T08:27:32Z

src/v1/database_admin_client.ts

@@ -61,6 +62,8 @@ export class DatabaseAdminClient {
  private _defaults: {[method: string]: gax.CallSettings};
  private _universeDomain: string;
  private _servicePath: string;
+  private _log = logging.log('spanner');


Are these changes manual ?

alkatrivedi requested review from a team as code owners April 1, 2025 08:47

product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Apr 1, 2025