Skip to content

feat: add promise based signatures for createQueryPartitions #2284

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 15 commits into from
May 6, 2025
Merged

feat: add promise based signatures for createQueryPartitions #2284

merged 15 commits into from
May 6, 2025
+93 −19

Conversation

alkatrivedi
Copy link
Contributor

fixes: #1899

@alkatrivedi alkatrivedi requested review from a team as code owners April 20, 2025 11:15
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Apr 20, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 20, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 20, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 28, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 30, 2025
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 1, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2025
surbhigarg92
surbhigarg92 reviewed May 5, 2025
View reviewed changes
@surbhigarg92
Copy link
Contributor

execute method should also be modified to support both promise and callback. https://github.com/googleapis/nodejs-spanner/blob/main/src/batch-transaction.ts#L329

@alkatrivedi alkatrivedi force-pushed the fix-batch-transaction branch from f3eb753 to c4c148c Compare May 5, 2025 15:00
@alkatrivedi alkatrivedi changed the title fix: error on using createQueryPartitions with await feat: add promise based signatures for createQueryPartitions May 6, 2025
@alkatrivedi alkatrivedi merged commit 255d8a6 into main May 6, 2025
21 of 23 checks passed
@alkatrivedi alkatrivedi deleted the fix-batch-transaction branch May 6, 2025 08:55
@release-please release-please bot mentioned this pull request May 6, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Promise functions on BatchTransaction
3 participants
@alkatrivedi @surbhigarg92 @yoshi-kokoro