-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: refactor connect() function, cover it with unit tests #462
Conversation
@c24t, I don't see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor blocking comments, but the changes look great otherwise.
Another option is to change isort's config to appease black.
We had to do this in another project here: open-telemetry/opentelemetry-python#104 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c24t, looks like comments are mostly about things that I'm just mimicking from other Cloud repos. It's not my preferences, so I'm ready to do however you (as a googler) decide
**self.settings_dict['OPTIONS'], | ||
"project": self.settings_dict["PROJECT"], | ||
"instance_id": self.settings_dict["INSTANCE"], | ||
"database_id": self.settings_dict["NAME"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed arg names here, other changes in the file are just about formatting
Run formatters.
Fit doclines, variable names and function args to the original Spanner client fashion.
Cover the function with unit tests.
Closes #460