Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: update docs and nox file to compile it #610

Merged
merged 10 commits into from
Apr 28, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Apr 22, 2021

feat: Docs files added and Nox file updated to compile it.

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner April 22, 2021 14:53
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Apr 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2021
@vi3k6i5 vi3k6i5 changed the title feat: Nox file fix feat: Docs added and Nox file updated to compile it Apr 22, 2021
@vi3k6i5 vi3k6i5 force-pushed the nox_file_fix branch 4 times, most recently from 526bc00 to 1570343 Compare April 22, 2021 15:24
@vi3k6i5 vi3k6i5 requested review from skuruppu and larkee April 22, 2021 15:26
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nit: PR title should be in present tense (e.g. update docs and nox file)

@vi3k6i5 vi3k6i5 changed the title feat: Docs added and Nox file updated to compile it feat: update docs and nox file to compile it Apr 24, 2021
@vi3k6i5 vi3k6i5 force-pushed the nox_file_fix branch 2 times, most recently from 4f050c8 to 21e28a2 Compare April 28, 2021 14:51
@vi3k6i5 vi3k6i5 merged commit 876f2fc into googleapis:master Apr 28, 2021
vi3k6i5 added a commit to vi3k6i5/python-spanner-django that referenced this pull request Apr 28, 2021
feat: update docs and nox file to compile it (googleapis#610)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nox target for django tests
2 participants