Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docfx session does not run for python-spanner-django #768

Open
dandhlee opened this issue May 31, 2022 · 2 comments
Open

docfx session does not run for python-spanner-django #768

dandhlee opened this issue May 31, 2022 · 2 comments
Assignees
@dandhlee
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dandhlee
Copy link
Contributor

Noticed this on #767, not sure what could be wrong. Will investigate.
@dandhlee dandhlee added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 31, 2022
@dandhlee dandhlee self-assigned this May 31, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label May 31, 2022
@dandhlee dandhlee mentioned this issue Jul 14, 2022
Closed
@IlyaFaer
Copy link
Contributor

IlyaFaer commented Jul 15, 2022 •
edited
Loading

@dandhlee, I've investigated it a bit. The problem is happening for this class:

python-spanner-django/django_spanner/base.py

Line 22 in 7312906

class DatabaseWrapper(BaseDatabaseWrapper):

I've added try-except into docfx function to log what's happening there, see this:

Untitled

So, source wasn't built for the class DatabaseWrapper

@dandhlee
Copy link
Contributor Author

Ah, I think the bigger issue is that it's using Sphinx V5, which has a loooot of breaking changes. I'll pin to use Sphinx v4.

@dandhlee dandhlee mentioned this issue Jul 15, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dandhlee dandhlee

Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): pin sphinx to use v4 googleapis/python-spanner-django
2 participants
@IlyaFaer @dandhlee