Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Send --dev_samples to Artman via additional arguments to gapic.{lang}_library #223

Closed
tswast opened this issue Apr 12, 2019 · 1 comment · Fixed by #224
Closed

Send --dev_samples to Artman via additional arguments to gapic.{lang}_library #223

tswast opened this issue Apr 12, 2019 · 1 comment · Fixed by #224
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@tswast
Copy link
Contributor

tswast commented Apr 12, 2019

I'd like to be able to generate Python code samples via synthtool, but as of googleapis/gapic-generator#2625, this requires an additional --dev_samples argument to artman.

I see that Artman.run accepts an arbitrary number of additional flags to artman via

map(str, ["artman", "--local", "--config", config, "generate"] + list(args))

but, there is no way to pass extra parameters from gapic.py_library.

output_root = artman.Artman().run(

@tswast
Copy link
Contributor Author

tswast commented Apr 12, 2019

I see a couple of alternatives to solving this issue:

  • Add additional artman args list as a parameter to py_library. Then, set additional_artman_args=["--dev_samples"] in my synth.py file to enable sample generation.
  • Add a parameter specifically for generating samples, e.g. include_samples=True.

My preference is to add additional_artman_args, but maybe there's a reason for adding separate parameters per artman flag?

@tswast tswast self-assigned this Apr 12, 2019
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 13, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants