Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Vec + custom write logic instead of BTreeSet for NameRecords #1170

Open
cmyr opened this issue Oct 2, 2024 · 0 comments
Open

Use Vec + custom write logic instead of BTreeSet for NameRecords #1170

cmyr opened this issue Oct 2, 2024 · 0 comments

Comments

@cmyr
Copy link
Member

cmyr commented Oct 2, 2024

This will achieve the same thing (ensuring that we always sort before writing) but will have slightly better ergonomics.

We'll also need to make sure we dedup before writing.

We don't have mutable access to the objects when writing them. We could provide custom logic for writing that handled the sorting (there's an annotation for that) and given that we need a custom annotation anyway (to specify that we use BTreeSet, here) maybe that would be preferable? Shouldn't be too tricky...

Originally posted by @cmyr in #1162 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant