You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
when this private lib key "com.github.googlei18n.ufo2ft.featureWriters" is present, ufo2ft uses this list instead of the built-in list of feature writers to generate things like kern or mark/mkmk features.
In this particular case, this has the effect of not building mark/mkmk features for Lunasima font, and as a result, no GPOS table is generated when this is built using fontmake (there isn't any kerning either...).
fontc instead ignores this and goes on to build mark/mkmk from the glyph anchors and a non-empty GPOS is built.
ttx_diff.py understandably reports a very bad score for Lunasima
Ideally ttx_diff could check for this lib key and tell fontc to only build mark or kern or neither accordingly.
The text was updated successfully, but these errors were encountered:
I immediately wonder if this could be converted to a config.yaml entry. Auditing what it's used for might be interesting. If it's widely used fontc might need to support.
I think it makes sense to handle this in fontc directly, checking for the presence of this key? Longer term we're going to need to move off of attributes that directly expose the implementation details of the existing compiler (e.g. we could just have keys for 'skip mark feature generation' or 'skip kern feature generation')
In https://github.com/docrepair-fonts/lunasima-fonts - sources/masters/Lunasima-Regular.ufo/lib.plist contains
when this private lib key "com.github.googlei18n.ufo2ft.featureWriters" is present, ufo2ft uses this list instead of the built-in list of feature writers to generate things like kern or mark/mkmk features.
In this particular case, this has the effect of not building mark/mkmk features for Lunasima font, and as a result, no GPOS table is generated when this is built using fontmake (there isn't any kerning either...).
fontc instead ignores this and goes on to build mark/mkmk from the glyph anchors and a non-empty GPOS is built.
ttx_diff.py understandably reports a very bad score for Lunasima
Ideally ttx_diff could check for this lib key and tell fontc to only build mark or kern or neither accordingly.
The text was updated successfully, but these errors were encountered: