From ffaf8e5942c6173879defbfb248effcac616b85b Mon Sep 17 00:00:00 2001 From: Marc Foley Date: Thu, 14 Dec 2023 10:37:19 +0000 Subject: [PATCH] post gh report then raise exit code --- Lib/gftools/qa.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Lib/gftools/qa.py b/Lib/gftools/qa.py index ccbbc12da..c5be76395 100644 --- a/Lib/gftools/qa.py +++ b/Lib/gftools/qa.py @@ -122,9 +122,6 @@ def fontbakery(self, profile="googlefonts", html=False, extra_args=None): if extra_args: cmd.extend(extra_args) process = subprocess.run(cmd) - if process.returncode != 0: - logger.fatal("Fontbakery has raised a fatal error. Please fix!") - sys.exit(1) fontbakery_report = os.path.join(self.out, "Fontbakery", "report.md") if not os.path.isfile(fontbakery_report): @@ -136,6 +133,10 @@ def fontbakery(self, profile="googlefonts", html=False, extra_args=None): msg = doc.read() self.post_to_github(msg) + if process.returncode != 0: + logger.fatal("Fontbakery has raised a fatal error. Please fix!") + sys.exit(1) + def googlefonts_upgrade(self, imgs=False): self.fontbakery() self.diffenator()