-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Align hhea to sTypoMetrics when useTypoMetrics flag is set? #346
Comments
by default the hhea linegap is set to 0, and the hhea.ascender also includes the typoLineGap (thus it is wider than the typoAscender). This is because a non-zero hhea.lineGap would increase the effective line spacing on some Windows environment (see "external leading" in https://docs.microsoft.com/en-us/typography/opentype/spec/recom#baseline-to-baseline-distances). I think ufo2ft doesn't do anything special when that useTypoMetrics flag is set, it simply compiles it as is. |
Maybe we should also set useTypoMetrics by default |
Not sure. There are still problems with e.g. linux text rendering libraries not doing line gap. |
As a follow up on this, I was looking at the Vertical Metrics instructions on the GoogleFonts docs and it makes this recommendation:
Thoughts? |
Sounds as sensible as any other strategy I suppose. There are a few, foundries like to have their own and applications all do whatever they want anyway. Ideally, you settle on one and explicitly set what you want in your source files. Don't rely on defaults. |
Agreed. I just figure might as well follow the Google Fonts standard as default as this is under the Google Fonts repository :) |
@madig do you have more information on this comment in the thread above?
What GNU/Linux env issues are at play with line spacing and typo v metrics? |
You can follow the links in https://gitlab.gnome.org/GNOME/cantarell-fonts/-/issues/37. |
tyvm! |
I am implementing a production pipeline for Cascadia Code using a UFO-based build workflow and have set the 'useTypoMetrics' flag in the font. As such, I'd expect the hhea values to be the same as the sTypoMetrics values, but instead it appears that the hhea values are aligning with the winAscent and winDescent values.
If that flag is set, shouldn't the hhea and sTypoMetrics be the same?
The text was updated successfully, but these errors were encountered: