Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MakePicture methods always create new TargetPicture #57

Open
duysqubix opened this issue Oct 10, 2023 · 0 comments
Open

MakePicture methods always create new TargetPicture #57

duysqubix opened this issue Oct 10, 2023 · 0 comments

Comments

@duysqubix
Copy link
Contributor

Look at batch.go#L82 and canvas.go#L73
All MakePicture methods return new TargetPicture instances.
Also every Sprite caches a TargetPicture.
So, does that means, for 10k Sprites created from a single Picture, pixel creates 10k TargetPictures?
That sounds very inefficient!

Original issue: faiface/pixel#178

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant