From fdeb7bc314fecece4e261b048f5fee1cb80208fe Mon Sep 17 00:00:00 2001 From: Sean Walberg Date: Sat, 12 May 2018 23:09:30 -0400 Subject: [PATCH] [docs] Doc fix for testing variables in path (#374) The example in the README does not pass the request through a mux therefore the request variables from the path are never populated. Update the sample to create a minimum viable router to use. Fixes #373 --- README.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 8f55ddcd..e424397a 100644 --- a/README.md +++ b/README.md @@ -601,8 +601,11 @@ func TestMetricsHandler(t *testing.T) { } rr := httptest.NewRecorder() - handler := http.HandlerFunc(MetricsHandler) - handler.ServeHTTP(rr, req) + + // Need to create a router that we can pass the request through so that the vars will be added to the context + router := mux.NewRouter() + router.HandleFunc("/metrics/{type}", MetricsHandler) + router.ServeHTTP(rr, req) // In this case, our MetricsHandler returns a non-200 response // for a route variable it doesn't know about.