Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature Request]: Delete tag when there are no more articles with that tag #782

Open
cirosantilli opened this issue Oct 30, 2021 · 1 comment
Assignees

Comments

@cirosantilli
Copy link
Contributor

cirosantilli commented Oct 30, 2021

Relevant Scope

Backend specs

Description

Currently there are no test that tags without any articles should be removed I think, but that is visible on /api/tags.

The nicer behavior would be to delete the tags when they are not needed anymore to not clutter the server.

I would just add a test for that under

"name":"Delete Article",
or

Part of the problem is that some of the tests appear to expect a non-clean server, so the full tag list might be unknown, so the tags test doesn't really seem to assert a precise test list.

I recommend that we just drop this philosophy, and instead focus on testing in a clean test environment always, with a controlled tag list.

My initial motivation for this is to help keep a demoserver data limited. But I don't want to cron delete things, I'd rather "delete if there are too many and a new one is added" basis.

Implementing it in SQL properly also requires LOCKing which would serve as a valuable example.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

@geromegrignon
Copy link
Contributor

Agreed!

I chose to rely on a cron for the current API demo as I was urged to move forward to fix the NSFW situation.

To add LOCKing is entirely part of the changes I plan for the v2: both for the demo and the specs.
I'm not satisfied by the current API specs as there aren't guidelines about the database schema expectations, regardless of how to generate it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants