Additional metadata to understand "usability" of a card #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouline
requested changes
Oct 9, 2024
| @@ -128,6 +130,8 @@ def extract_exposures( | |||
| result = self.__extract_card_exposures(ctx, card=entity) | |||
| depends.update(result["depends"]) | |||
| native_query = result["native_query"] | |||
| average_query_time_ms = entity.get('average_query_time') | |||
| last_used_at_utc = entity['last_used_at'] | |||
There was a problem hiding this comment.
Should be an optional get() as well
Comment on lines
+115
to
+116
| average_query_time_ms = None | ||
| last_used_at_utc = None |
There was a problem hiding this comment.
Since you're retrieving them as-is from Metabase, keep the naming identical (i.e. no _ms and _at_utc)
Comment on lines
+360
to
+361
| else: | ||
| average_query_time = "n.a." |
There was a problem hiding this comment.
If not provided, shouldn't be included at all
| @@ -360,6 +373,10 @@ def __format_exposure( | |||
| "email": creator_email, | |||
| }, | |||
| "depends_on": list(depends_on), | |||
| "meta": { | |||
| "avg_query_time": average_query_time, | |||
| "last_used_at_utc": last_used_at_utc or 'n.a.' | |||
There was a problem hiding this comment.
Same here, if not provided, shouldn't be included at all (build up meta conditionally as a dictionary variable and only set it when not empty)
| @@ -346,6 +354,11 @@ def __format_exposure( | |||
| + f"Created On: __{created_at}__" | |||
| ) | |||
|
|
|||
| if average_query_time_ms: | |||
| average_query_time_s = average_query_time_ms // 1000 | |||
| average_query_time = f"{int(average_query_time_s // 60)}:{str(int(average_query_time_s % 60)).zfill(2)}" | |||
There was a problem hiding this comment.
If the original value is in milliseconds (i.e. 1000th), why are you zfill'ing with only 2 and not 3?
gouline
added a commit
that referenced
this pull request
Oct 12, 2024
* Feat: avg query time + last used at timestamp (#281) * Query average time and last usage metadata --------- Co-authored-by: Simon Rosenberger (Bumm) <41942954+codingcyclist@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #280