Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Buttons and body clash with defaults #197

Closed
steveworley opened this issue Jun 12, 2017 · 1 comment
Closed

Buttons and body clash with defaults #197

steveworley opened this issue Jun 12, 2017 · 1 comment
Assignees
Labels
🐛 bug Something isn’t working the way it should. module: buttons An issue or pull request related to the button component.

Comments

@steveworley
Copy link

I just came across a bit of an issue with the default settings when using multiple modules together.

$uikit-colour-Font: #313131;
$uikit-colour-Secondary: #313131;

The body module provides a style for all links in .uikit-body a which supersedes the uikit button style which only references .uikit-btn--secondary. .uikit-btn sets the font colour but is not specific enough.

Should the button styles for links be more specific so they're not lost when the body module is used?

Here are some examples:

image

image

@dominikwilkowski dominikwilkowski self-assigned this Jun 13, 2017
@dominikwilkowski dominikwilkowski added 🐛 bug Something isn’t working the way it should. module: buttons An issue or pull request related to the button component. uikit labels Jun 13, 2017
@dominikwilkowski
Copy link
Contributor

Thanks for reporting this @steveworley

We didn't catch this as buttons were not supposed to be links :) but buttons. I recently gave in via #162 but would still strongly suggest to use buttons where you mean "buttons".

In the meantime we will fix this. :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
🐛 bug Something isn’t working the way it should. module: buttons An issue or pull request related to the button component.
Projects
None yet
Development

No branches or pull requests

2 participants