Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

libposix4win.h #101

Open
ghost opened this issue Jun 4, 2023 · 1 comment
Open

libposix4win.h #101

ghost opened this issue Jun 4, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 4, 2023

windows.h must be included after winsock2.h, ws2tcpip.h and tlhelp32.h. You also forgot to include stdint.h.

There is no check for _MSC_VER so msvclibx.h will be always be included even though it's not part of the source with ENV_MINGW.

The same for pthreads4w headers, as I tell you MSYS2 doesn't need pthreads4w: #100

There are also no check for _MSC_VER so pthreads4w headers are always included. Don't you feel it silly? Imagine you are on Cygwin where pthreads is native, you still have to use pthreads4w?
@ghost ghost mentioned this issue Jun 4, 2023
Open
@gozfree
Copy link
Owner

gozfree commented Jul 23, 2023

msys2 env will follow linux makefile

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gozfree