Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The configuration skip should affect all goals #628

Open
klopfdreh opened this issue Oct 15, 2024 · 1 comment
Open

The configuration skip should affect all goals #628

klopfdreh opened this issue Oct 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@klopfdreh
Copy link

Describe the bug
I just tested it with native-maven-plugin (0.10.3), but I assume it is the same for the gradle plugin which should be checked.

You can apply configuration tag to executions and for the plugin in general. When applied to the plugin in general there should be a way to disable all goals which implies the tag skip at this level

Example:

<plugin>
    <groupId>org.graalvm.buildtools</groupId>
    <artifactId>native-maven-plugin</artifactId>
    <version>0.10.3</version>
    <configuration>
        <metadataRepository>
            <enabled>true</enabled>
        </metadataRepository>
        <requiredVersion>22.3</requiredVersion>
        <skip>true</skip>
    </configuration>
    <executions>
        <execution>
            <id>add-reachability-metadata</id>
            <goals>
                <goal>add-reachability-metadata</goal>
            </goals>
        </execution>
    </executions>
</plugin>

The goal add-reachability-metadata in this case is not skipped at all.

To Reproduce
Create a project with native-maven-plugin and apply skip to the configuration of the plugin.

Expected behavior
If you apply skip to the root configuration all goals should be disabled. add-reachability-metadata is executed anyway.

Logs
N/A

System Info (please complete the following information):

  • OS: Mac
  • GraalVM Version 22.3
  • Java Version 18
  • Plugin version native-maven-plugin:0.10.3

Additional context

My suggestion would to have a property for each goal to disable / enable it separately - e.g. <skipAddReachabilityMetaData> / <skipNativeBuild> / ... and one property to disable all at once <skip> at root level configuration tag.

@klopfdreh klopfdreh added the bug Something isn't working label Oct 15, 2024
@vjovanov
Copy link
Member

vjovanov commented Nov 4, 2024

Seems that the metadata fetch task ignores the skip argument. @alvarosanchez can you have a look at this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants