Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The setup-gradle action should make it easy to run with wrapper in an OS-agnostic way #308

Closed
bigdaz opened this issue Jul 22, 2024 · 2 comments
Labels
invalid This doesn't seem right

Comments

@bigdaz
Copy link
Member

bigdaz commented Jul 22, 2024

Now that the arguments parameter has been removed, it's inconvenient to write a matrix Job that tests against Windows and Ubuntu. This is because the execution step needs to differentiate between ./gradlew on Ubuntu and gradlew.bat on Windows.

To fix this, we should:

We could also make gradle-version: wrapper to fail if no wrapper is present, and have gradle-version: wrapper-or-path as the default.

@bigdaz bigdaz added this to the v4.0.0 milestone Jul 22, 2024
@cloudshiftchris
Copy link

Is there a need to even consider gradlew.bat?

This works fine on Windows runners to execute the wrapper:

      - name: Execute Gradle
        shell: bash
        run: |
          ./gradlew build

@bigdaz
Copy link
Member Author

bigdaz commented Jul 31, 2024

@cloudshiftchris You're absolutely correct. Even without the explicit shell configuration, the default shell on Windows (pwsh) runs ./gradlew just fine.

This issue was reported to me and I didn't test it until now :).

@bigdaz bigdaz closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
@bigdaz bigdaz removed this from the v4.0.0 milestone Jul 31, 2024
@bigdaz bigdaz added the invalid This doesn't seem right label Jul 31, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants