Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add possibility do add common labels in helm chart #3319

Closed
Rohlik opened this issue Sep 18, 2024 · 2 comments · Fixed by #3379, #3381, #3384 or #3385 · May be fixed by #3380
Closed

Add possibility do add common labels in helm chart #3319

Rohlik opened this issue Sep 18, 2024 · 2 comments · Fixed by #3379, #3381, #3384 or #3385 · May be fixed by #3380

Comments

@Rohlik
Copy link
Contributor

Rohlik commented Sep 18, 2024

Is your feature request related to a problem? Please describe.
There is no way how to easily set common labels across all Helm chart Tempo created resources, like (deployments, statefulsets, ingresses, services, servicemonitors, persistent volumes, etc). This leads to difficulties when you have common rules/alerts, for example, "almost full persistent volume" and you want to route them to the responsible owner based on the team label. This is now impossible as the PV/PVC doesn't have related labels 😢.

Describe the solution you'd like
In values.yaml, we should be able to specify something like this:

commonLabels:
  foo: bar
  label2: value2

and all resources created by the Tempo chart will have those labels.

Describe alternatives you've considered

Additional context
Sadly, the other components from Grafana are missing this support also 😣; see tickets below. It would be nice to have the same method for setting these common labels across charts.
@joe-elliott
Copy link
Member

I am fully in support of this. Moving this to the helm charts repo for visibility.

We would gladly take a PR to add this feature.

@joe-elliott joe-elliott transferred this issue from grafana/tempo Sep 19, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 26, 2024
@ftrigari
[tempo] Add commonLabels (grafana#3319)
3375efd 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
@ftrigari ftrigari mentioned this issue Oct 26, 2024
Closed
@ftrigari
Copy link
Contributor

I edited 3 Tempo Charts using the same logic used for Mimir chart.

I didn't edit dependency charts; I'm waiting for a feedback on how to proceed grafana/mimir#9067 (comment)

ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo] Add commonLabels (grafana#3319)
9eb8647 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo-distributed] Add commonLabels (grafana#3319)
3cc8dc6 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo-vulture] Add commonLabels (grafana#3319)
b567f80 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo] Update chart version (grafana#3319)
153633b 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
This was referenced Oct 29, 2024
Merged
Open
Merged
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo] Update README (grafana#3319)
1d34ce7 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo] Update README and chart version (grafana#3319)
1c12496 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo-vulture] Update README and chart version (grafana#3319)
cbe01ed 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo-distributed] Update README and chart version (grafana#3319)
93762a2 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo] Update README and chart version (grafana#3319)
32623d5 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[tempo] Removed comment (grafana#3319)
c1052a4 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[rollout-operator] Add commonLabels (grafana#3319)
007751e 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[rollout-operator] Add commonLabels (grafana#3319)
f77d201 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[agent-operator] Add commonLabels (grafana#3319)
116d74b 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
@ftrigari
[rollout-operator] Add commonLabels (grafana#3319)
fd5c88b 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
This was referenced Oct 29, 2024
Merged
Merged
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[rollout-operator] Add commonLabels (grafana#3319)
6b528e3 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[agent-operator] Add commonLabels (grafana#3319)
14b16a0 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[tempo-vulture] Add commonLabels (grafana#3319)
f8b72c3 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[tempo-vulture] Update README and chart version (grafana#3319)
efad248 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[tempo-distributed] Add commonLabels (grafana#3319)
f195767 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[tempo-distributed] Update README and chart version (grafana#3319)
4e3c4b0 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[tempo] Add commonLabels (grafana#3319)
1cca796 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[tempo] Update README and chart version (grafana#3319)
55b98d7 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[tempo] Removed comment (grafana#3319)
a267ff6 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
@ftrigari
[agent-operator] Add commonLabels (grafana#3319)
6ff8bb6 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
@ftrigari
[tempo-vulture] Add commonLabels (grafana#3319)
74160c2 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
@ftrigari
[tempo-vulture] Update README and chart version (grafana#3319)
711a08d 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
@ftrigari
[tempo-distributed] Add commonLabels (grafana#3319)
a5de9f5 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
@ftrigari
[tempo-distributed] Update README and chart version (grafana#3319)
ec2c8f2 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
@ftrigari
[tempo] Add commonLabels (grafana#3319)
e6d8d64 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
@ftrigari
[tempo] Update README and chart version (grafana#3319)
181c559 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
@ftrigari
[tempo] Removed comment (grafana#3319)
e307ca2 
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
zanhsieh added a commit that referenced this issue Nov 3, 2024
@zanhsieh
Merge pull request #3379 from ramon951/tempo
0d5f0b1 
[tempo] Add commonLabels (#3319)
zanhsieh added a commit that referenced this issue Nov 3, 2024
@zanhsieh
Merge pull request #3385 from ramon951/agent-operator
29bacb8 
[agent-operator] Add commonLabels (#3319)
Sheikh-Abubaker added a commit that referenced this issue Nov 5, 2024
@Sheikh-Abubaker
Merge pull request #3381 from ramon951/tempo-vulture
5dde332 
[tempo-vulture] Add commonLabels (#3319)
Sheikh-Abubaker added a commit that referenced this issue Nov 5, 2024
@Sheikh-Abubaker
Merge pull request #3384 from ramon951/rollout_operator
584dfd6 
[rollout-operator] Add commonLabels (#3319)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Rohlik @joe-elliott @ftrigari