Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Breaking: TempoQuery Startup #3417

Open
trevatk opened this issue Nov 10, 2024 · 4 comments
Open

Breaking: TempoQuery Startup #3417

trevatk opened this issue Nov 10, 2024 · 4 comments
Labels
bug Something isn't working helm help wanted Extra attention is needed

Comments

@trevatk
Copy link

trevatk commented Nov 10, 2024

TempoQuery is failing to start when enabled in helm chart with most recent version 1.13.0. Never looked at the source code for tempoQuery not sure if an argument would fix? But figured without supporting documentation it should not be released?

helm install tempo-grafana grafana/tempo --version 1.12.0 flag seems to work for now.

flag provided but not defined: -query.base-path Usage of /tempo-query: -config string A path to the plugin's configuration file

submitted a PR to revert breaking jump.
#3416

@trevatk trevatk changed the title TempoQuery Startup Breaking: TempoQuery Startup Nov 10, 2024
@paul-at-cybr
Copy link

paul-at-cybr commented Nov 11, 2024

+1 to this issue, also observing it here (on chart 1.14.0)

@Sheikh-Abubaker Sheikh-Abubaker added help wanted Extra attention is needed helm bug Something isn't working labels Nov 14, 2024
@jkleinlercher
Copy link

jkleinlercher commented Nov 24, 2024

+1 also from my side

may I add some additional infos, which probably helps:

when applying tempo helm chart with values .tempoQuery.enabled=true container tempo-query fails with

flag provided but not defined: -query.base-path
Usage of /tempo-query:
  -config string
    	A path to the plugin's configuration file

tempo-query container arg --query.base-path is defined in

It seems there was a breaking change for tempo-query in this release which is part of this helm chart update: https://github.com/grafana/tempo/releases/tag/v2.6.1

the specific pull request for this breaking change is: grafana/tempo#3840 provided by @frzifus

I think more or less the same changes which were done in the tempo-operator in grafana/tempo-operator#1025 need to get applied to the helm chart?

@frzifus
Copy link

frzifus commented Nov 24, 2024

Oh shoot, I was not aware that its directly deployed without the operator.
y, we need to do something like that. Deploy Jaeger query next to tempo query.
As of 1.58, Jaeger no longer supports the grpc plugin, so we've turned tempo-query into a standalone backend.

@zet694
Copy link

zet694 commented Dec 17, 2024

Hey! Any updates about this problem? I have same problem in 1.16.0 (chart: tempo, version: "1.16.0")

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working helm help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants