Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tracing: Jaeger/Opentracing are deprecated, use open-telemetry for instrumentation instead #6812

Open
kavirajk opened this issue Jul 31, 2022 · 2 comments
Open

tracing: Jaeger/Opentracing are deprecated, use open-telemetry for instrumentation instead #6812

kavirajk opened this issue Jul 31, 2022 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@kavirajk
Copy link
Contributor

kavirajk commented Jul 31, 2022 •
edited
Loading

Currently Loki is instrumented with opentracing/jaeger client libraries for tracing.

This instrumentation comes from weaveworks/common package and dskit's spanlogger package.

Those client libraries(opentracing, jaeger) are deprecated in the favor of opentelemetry client sdk. It's better to migrate.

I hope, It should be completely possible to migrate underlying dependencies without changing any API of those packages.

Example of using otel tracing client libraries for instrumentation in Go is here.
@kavirajk kavirajk added the dependencies Pull requests that update a dependency file label Jul 31, 2022
@kavirajk kavirajk changed the title tracing: Jaeger/Opentracing client libs are depreicated, use opentelmetry for instrumentation instead tracing: Jaeger/Opentracing client libs are depreicated, use opentelemetry for instrumentation instead Jul 31, 2022
@kavirajk kavirajk changed the title tracing: Jaeger/Opentracing client libs are depreicated, use opentelemetry for instrumentation instead tracing: Jaeger/Opentracing client libs are deprecated, use opentelemetry for instrumentation instead Jul 31, 2022
@kavirajk kavirajk mentioned this issue Aug 15, 2022
Open
@kavirajk kavirajk changed the title tracing: Jaeger/Opentracing client libs are deprecated, use opentelemetry for instrumentation instead tracing: Jaeger/Opentracing are deprecated, use open-telemetry for instrumentation instead Aug 15, 2022
@mateuszdrab
Copy link

Looking forward to see this implemented, I realized that Grafana sends trace headers in w3c format to Loki which it can't support due to the feature not being implemented in the jaeger libraries. OCD was triggered as I wanted Grafana, Loki and Thanos to all support tracing.

@davidspek
Copy link

Just wanted to note that weaveworks/common isn't being used anymore and that grafana/dskit#385 is the PR needed to migrate to OTEL.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kavirajk @mateuszdrab @davidspek