From 8aa03db64bae43d1605eb5a09ace246545e81b3e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=B0nan=C3=A7=20G=C3=BCm=C3=BC=C5=9F?=
 <inanc.gumus@grafana.com>
Date: Wed, 13 Dec 2023 14:59:17 +0300
Subject: [PATCH] Add tests for ExecutablePath

---
 chromium/browser_type_test.go | 86 +++++++++++++++++++++++++++++++++++
 1 file changed, 86 insertions(+)

diff --git a/chromium/browser_type_test.go b/chromium/browser_type_test.go
index 47cf31a4c..44ecaa6d0 100644
--- a/chromium/browser_type_test.go
+++ b/chromium/browser_type_test.go
@@ -1,10 +1,13 @@
 package chromium
 
 import (
+	"io/fs"
 	"net"
+	"path/filepath"
 	"testing"
 
 	"github.com/grafana/xk6-browser/common"
+	"github.com/grafana/xk6-browser/env"
 
 	k6lib "go.k6.io/k6/lib"
 	"go.k6.io/k6/lib/types"
@@ -150,3 +153,86 @@ func TestBrowserTypePrepareFlags(t *testing.T) {
 		})
 	}
 }
+
+func TestExecutablePath(t *testing.T) {
+	t.Parallel()
+
+	// we pick a random file name to look for in our tests
+	// this doesn't matter as long as it's in the paths we look for
+	// in ExecutablePath function.
+	const chromiumExecutable = "google-chrome"
+
+	tests := map[string]struct {
+		path        string                            // user provided path
+		lookPath    func(file string) (string, error) // determines if a file exists
+		userProfile env.LookupFunc
+
+		wantPath string
+		wantOK   bool
+	}{
+		"without_chromium": {
+			path: "", // user did not provide a path
+			lookPath: func(file string) (string, error) {
+				return "", fs.ErrNotExist
+			},
+			userProfile: env.EmptyLookup,
+			wantPath:    "", // no path should be returned
+			wantOK:      false,
+		},
+		"with_chromium": {
+			path: "",
+			lookPath: func(file string) (string, error) {
+				if file == chromiumExecutable {
+					return "", nil
+				}
+				return "", fs.ErrNotExist
+			},
+			userProfile: env.EmptyLookup,
+			wantPath:    chromiumExecutable,
+			wantOK:      true,
+		},
+		"path_override_without_chromium": {
+			path: filepath.Join("path", "to", "chromium"),
+			lookPath: func(file string) (string, error) {
+				return "", fs.ErrNotExist
+			},
+			userProfile: env.EmptyLookup,
+			wantPath:    filepath.Join("path", "to", "chromium"),
+			wantOK:      true,
+		},
+		"path_override_with_chromium": {
+			path: filepath.Join("path", "to", "chromium"),
+			lookPath: func(file string) (string, error) {
+				if file == chromiumExecutable {
+					return "", nil
+				}
+				return "", fs.ErrNotExist
+			},
+			userProfile: env.EmptyLookup,
+			wantPath:    filepath.Join("path", "to", "chromium"),
+			wantOK:      true,
+		},
+		"user_profile": {
+			path: "",
+			lookPath: func(file string) (string, error) { // we look chrome.exe in the user profile
+				if file == filepath.Join("home", `AppData\Local\Google\Chrome\Application\chrome.exe`) {
+					return "", nil
+				}
+				return "", fs.ErrNotExist
+			},
+			userProfile: env.ConstLookup("USERPROFILE", `home`),
+			wantPath:    filepath.Join("home", `AppData\Local\Google\Chrome\Application\chrome.exe`),
+			wantOK:      true,
+		},
+	}
+	for name, tt := range tests {
+		tt := tt
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
+			path, ok := ExecutablePath(tt.path, tt.userProfile, tt.lookPath)
+			assert.Equal(t, tt.wantPath, path)
+			assert.Equal(t, tt.wantOK, ok)
+		})
+	}
+}