From 0d9446c5956234e9b6ef85a0b343e69c2a5615b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=B0nan=C3=A7=20G=C3=BCm=C3=BC=C5=9F?= Date: Fri, 16 Feb 2024 11:14:16 +0300 Subject: [PATCH] Remove goja from newPointerAction offsetPosition is the only one using Goja. Removed. --- common/element_handle.go | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/common/element_handle.go b/common/element_handle.go index 0b1deb418..69d8ec17e 100644 --- a/common/element_handle.go +++ b/common/element_handle.go @@ -399,21 +399,9 @@ func (h *ElementHandle) offsetPosition(apiCtx context.Context, offset *Position) return nil, err } - rt := h.execCtx.vu.Runtime() var border struct{ Top, Left float64 } - switch result := result.(type) { - case goja.Value: - if result != nil && !goja.IsUndefined(result) && !goja.IsNull(result) { - obj := result.ToObject(rt) - for _, k := range obj.Keys() { - switch k { - case "left": - border.Left = obj.Get(k).ToFloat() - case "top": - border.Top = obj.Get(k).ToFloat() - } - } - } + if err := convert(result, &border); err != nil { + return nil, fmt.Errorf("converting result (%v of type %t) to border: %w", result, result, err) } box := h.BoundingBox()