Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve handling of unsupported subgraph indexing networks #728

Open
fordN opened this issue Aug 16, 2023 · 4 comments
Open

Improve handling of unsupported subgraph indexing networks #728

fordN opened this issue Aug 16, 2023 · 4 comments
Assignees
Labels

Comments

@fordN
Copy link
Contributor

fordN commented Aug 16, 2023

The UX for unsupported subgraphs is leaving a lot to be desired right now.

Why?

  • We do not support indexing rules that specify the indexed network, so often subgraphs are identified for allocation that the graph-node cannot support.
  • Deployments for unsupported subgraphs are attempted repeatedly and included in prometheus error metrics leading to false alarms in alerting and monitoring

These UX issues are amplified on a larger scale indexer like some of the E&N indexers. If subgraph deployments are hand selected by the indexer these pain points will likely not be exposed.

@fordN fordN changed the title Improve handling of unsupported networks Improve handling of unsupported subgraph indexing networks Aug 16, 2023
@fordN fordN added enhancement New feature or request indexer-agent labels Aug 16, 2023
@fordN fordN added this to Indexer Aug 16, 2023
@github-project-automation github-project-automation bot moved this to 🗃️ Inbox in Indexer Aug 16, 2023
@fordN
Copy link
Contributor Author

fordN commented Aug 16, 2023

Brainstorming some solutions:

  • Indexing rules could specify an indexing network which would allow the indexer to be selective about which indexing networks they support.
  • The indexer-agent could query the graph-node instances to see what chains are supported and automatically disqualify subgraph deployments that sync an unsupported chain or feature.
  • Error handling could be improved to simply make the unsupported network errors less chatty.

@fordN fordN added the p1 label Sep 25, 2023
@fordN fordN moved this from 🗃️ Inbox to 📒 Todo in Indexer Sep 25, 2023
@fordN
Copy link
Contributor Author

fordN commented Sep 25, 2023

Related to graphprotocol/allocation-optimizer#42

@alex-pakalniskis alex-pakalniskis added this to the Indexer Experience milestone Sep 26, 2023
@alex-pakalniskis
Copy link
Contributor

#836

@alex-pakalniskis
Copy link
Contributor

#894

@fordN fordN moved this from 📒 Todo to ⌛ Up next in Indexer Jul 10, 2024
@dwerner dwerner self-assigned this Jul 10, 2024
@dwerner dwerner moved this from ⌛ Up next to 🏗️ In Progress in Indexer Feb 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: 🏗️ In Progress
Development

No branches or pull requests

3 participants