Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add --format=json playback option #4578

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Add --format=json playback option #4578

merged 2 commits into from
Nov 8, 2020

Conversation

klizhentas
Copy link
Contributor

@fspmarshall @russjones I was debugging new format playback files, and built this function:

This commit fixes #4577, updates #1580

$ tsh play --format=json ~/play/0c0b81ed-91a9-4a2a-8d7c-7495891a6ca0.tar | jq '.event
"print"
"print"
"session.disk"

In the future I will add tsh play ~/.... to complete #1580, but for now we have a useful tool to introspect sessions.

@klizhentas klizhentas requested a review from awly as a code owner October 17, 2020 22:04
@benarent benarent added docs-required c-ib Internal Customer Reference labels Oct 20, 2020
fspmarshall
fspmarshall approved these changes Oct 20, 2020
View reviewed changes
lib/events/playback.go Outdated Show resolved Hide resolved
@benarent
Copy link
Contributor

benarent commented Nov 3, 2020

@russjones We've a request from a customer to put this into 5.0? can you review this week if that's possible?

klizhentas and others added 2 commits November 8, 2020 05:08
@klizhentas @russjones
Add --format=json playback option
e940d2c 
This commit fixes #4577, updates #1580

```bash
$ tsh play --format=json ~/play/0c0b81ed-91a9-4a2a-8d7c-7495891a6ca0.tar | jq '.event
"print"
"print"
"session.disk"
```
@russjones
Removed logic to export to text format.
096a687
@russjones russjones merged commit c047750 into master Nov 8, 2020
@russjones russjones deleted the sasha/export branch November 8, 2020 16:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@russjones russjones russjones approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

@webvictim webvictim Awaiting requested review from webvictim

@awly awly Awaiting requested review from awly

@a-palchikov a-palchikov Awaiting requested review from a-palchikov

@r0mant r0mant Awaiting requested review from r0mant

Assignees
No one assigned
Labels
c-ib Internal Customer Reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to export playbacks to JSON
4 participants
@klizhentas @benarent @russjones @fspmarshall