Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow custom HTTP headers in API requests provided through the environment #9375

Closed
stouset opened this issue Dec 13, 2021 · 5 comments
Closed
Labels
c-ct Internal Customer Reference c-sq Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@stouset
Copy link

stouset commented Dec 13, 2021

What

Square requires connections to internal systems to transit through a BeyondCorp web proxy. Authentication is performed against this proxy by including a custom authentication cookie to proxied HTTP requests.

We'd like to be able to configure the teleport client to issue requests with these headers. Additionally, we'd like teleport to respect the existence of https_proxy and http_proxy environment variables through http.ProxyFromEnvironment.

How

  1. all http.Client initialization should configure the client with Proxy: http.ProxyFromEnvironment.

  2. HTTP clients that fallback to insecure should allow doing so if either the request URL is a localhost address (current behavior) or if the proxy is a localhost address.

  3. HTTP clients should look for an environment variable (suggested: TELEPORT_WEBCLIENT_HEADERS). When this variable is present, the headers contained within should be passed on through to HTTP client requests.

Why

To get through Square's BeyondCorp authenticating proxy.

Workaround

Unfortunately no workaround exists.

@stouset stouset added the feature-request Used for new features in Teleport, improvements to current should be #enhancements label Dec 13, 2021
@stouset
Copy link
Author

stouset commented Dec 13, 2021

For 1 and 2: #9376

@stouset
Copy link
Author

stouset commented Dec 13, 2021

For 3: #9377

@stouset
Copy link
Author

stouset commented Dec 15, 2021

Closes #6831

@stouset stouset mentioned this issue Dec 17, 2021
@pschisa pschisa added c-ct Internal Customer Reference c-sq Internal Customer Reference labels Jan 11, 2022
@klizhentas
Copy link
Contributor

Removing needs-product-decision see discussion and comments on:

#9475

@r0mant
Copy link
Collaborator

r0mant commented Dec 30, 2022

This was implemented in #10336.

@r0mant r0mant closed this as completed Dec 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c-ct Internal Customer Reference c-sq Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

No branches or pull requests

5 participants