Skip to content

fix(coding-standard)!: use magento/php-compatibility-fork #190

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Apr 9, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, the coding standard actions are failing due to a problem with phpcompatibility/php-compatibility that resulted in a fork by Adobe: magento/php-compatibility-fork.

Fixes: N/A

What is the new behavior?

We use the new fork.

Does this PR introduce a breaking change?

  • Yes
  • No

This MAY be a breaking change if you depended on something specifically from phpcompatibility/php-compatibility. Additionally, this action is no longer compatible with Magento < 2.4.4.

Other information

@damienwebdev damienwebdev merged commit 0008e86 into main Apr 9, 2025
@damienwebdev damienwebdev deleted the coding_standard_compat branch April 9, 2025 13:46
@gray-bot gray-bot mentioned this pull request Apr 9, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant