Skip to content

feat(supported-version): add user-defined kind #28

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 10 commits into from
Aug 5, 2022

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Aug 5, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, supported version spits out the matrix of ALL currently supported versions of Magento by Adobe. One may not always want to support that wide of a matrix.

Fixes: #15

What is the new behavior?

We now offer custom and latest in order to allow users to more precisely define what they want.

jobs:
  compute_matrix:
    runs-on: ubuntu-latest
    outputs:
      matrix: ${{ steps.supported-version.outputs.matrix }}
    steps:
      - uses: actions/checkout@v2
      - uses: graycoreio/github-actions-magento2/supported-version@main
        id: supported-version
jobs:
  compute_matrix:
    runs-on: ubuntu-latest
    outputs:
      matrix: ${{ steps.supported-version.outputs.matrix }}
    steps:
      - uses: actions/checkout@v2
      - uses: graycoreio/github-actions-magento2/supported-version@main
        id: supported-version
        inputs:
            kind: 'latest'
jobs:
  compute_matrix:
    runs-on: ubuntu-latest
    outputs:
      matrix: ${{ steps.supported-version.outputs.matrix }}
    steps:
      - uses: actions/checkout@v2
      - uses: graycoreio/github-actions-magento2/supported-version@main
        id: supported-version
        inputs:
            kind: 'custom'
            custom_versions: 'magento/project-community-edition:2.3.7-p3,magento/project-community-edition:2.4.0'
             

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@damienwebdev damienwebdev force-pushed the supported_version_change branch from f439634 to 076dd83 Compare August 5, 2022 15:42
`kind` is a new input property for the `supported-version` action which
allows one to define what specific versions of Magento they support.

Currently, `kind` supports `latest`, `supported`, and `custom`. See the
README for `supported-version` if you want more specifics
@damienwebdev damienwebdev force-pushed the supported_version_change branch from 076dd83 to d2ce48f Compare August 5, 2022 15:42
@damienwebdev damienwebdev changed the title Supported version change feat(supported-version): add user-defined kind Aug 5, 2022
@damienwebdev damienwebdev self-assigned this Aug 5, 2022
@damienwebdev damienwebdev merged commit 664360e into main Aug 5, 2022
@damienwebdev damienwebdev deleted the supported_version_change branch August 12, 2022 12:05
@gray-bot gray-bot mentioned this pull request Mar 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change supported-version to just be version and supported becomes one kind
2 participants