Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inclusion in YCSB project? #1

Open
busbey opened this issue Sep 3, 2018 · 7 comments
Open

Inclusion in YCSB project? #1

busbey opened this issue Sep 3, 2018 · 7 comments

Comments

@busbey
Copy link

busbey commented Sep 3, 2018

Hi folks!

I'm getting set to do some cleanup on the YCSB project focused on getting old PRs that needed a bit of polish merged.

There's one for adding GridDB support:

brianfrankcooper/YCSB#1018

There's an open question on wether y'all would prefer to maintain your client binding as an independent project or have it merged into YCSB. Either way is fine by me, do y'all have a preference?

@knonomura
Copy link
Member

Thank you very much for the information.

Sorry we weren't aware of the PR for adding the GridDB support.
We'd be happy to merge the GridDB connector to YCSB project.

Thanks.

@busbey
Copy link
Author

busbey commented Sep 5, 2018

that's great! I imagine that at this point the existing PR is a bit stale. would y'all like to bring the current one up to speed with this repository? Would you prefer to just make a new PR?

@knonomura
Copy link
Member

If possible, we'd like to proceed with the former.

@knonomura
Copy link
Member

I have an additional information.

This connector has a dependency with GridDB Java Client (gridstore.jar),
but it isn't registered on Maven Central Repository yet.

So, for the build environment, I am thinking of the following approach:

Step 1. Enable build from YCSB binary with local Java Client (jar) <-- the current
Step 2. Enable build from YCSB source code with local Java Client (jar)
Step 3. Enable build from YCSB source code with Java Client on Maven Central Repository

I will make another PR for Step 2 around next week, but Step 3 may take some time.

@knonomura
Copy link
Member

Step 1. Enable build from YCSB binary with local Java Client (jar)
Step 2. Enable build from YCSB source code with local Java Client (jar) <-- the current
Step 3. Enable build from YCSB source code with Java Client on Maven Central Repository

I am currently undergoing Step 3.

@busbey
Copy link
Author

busbey commented Jan 31, 2019

👍

@knonomura
Copy link
Member

Just now I finished Step 3.

Step 1. Enable build from YCSB binary with local Java Client (jar)
Step 2. Enable build from YCSB source code with local Java Client (jar)
Step 3. Enable build from YCSB source code with Java Client on Maven Central Repository <-- the current

Could you please check my PR ?
brianfrankcooper/YCSB#1258

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants