Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add config for linter #17

Closed
bkircher opened this issue Mar 18, 2022 · 1 comment · Fixed by #18
Closed

Add config for linter #17

bkircher opened this issue Mar 18, 2022 · 1 comment · Fixed by #18
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bkircher
Copy link
Contributor

Right now there is no config for any linter in this project.

Things to do:

  • Choose a linter
  • Create a config for that linter
  • Make lint run pass without warnings (either by fixing issues in code or by silencing individual warnings in the config)
  • Add GH Action task that runs this linter with that config on the project

We could use pylint or flake8. Personally, I would prefer pylint because I know it best but no hard feelings. I could gift an initial config file for pylint.
@bkircher bkircher added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 18, 2022
@bkircher
Copy link
Contributor Author

I just realized oh much code this repository contains.

tokei .                 
===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 INI                     1            4            2            1            1
 Python                480        99624        82993         1298        15333
 Plain Text              1            9            0            9            0
-------------------------------------------------------------------------------
 Markdown                4          446            0          342          104
 |- Python               1           31           19            6            6
 |- Shell                1            5            5            0            0
 (Total)                            482           24          348          110
===============================================================================
 Total                 486       100119        83019         1656        15444
===============================================================================

Guess, mostly is generated and then added to the source tree.

@bkircher bkircher mentioned this issue Mar 18, 2022
Merged
@BoxG11 BoxG11 linked a pull request Mar 28, 2022 that will close this issue
Feature/17 add config for linter #18
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/17 add config for linter gridscale/gridscale_api_client_python
1 participant
@bkircher