Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix GFN-FF parallelisation issues for numerical differentiation #361

Closed
awvwgk opened this issue Oct 4, 2020 · 0 comments · Fixed by #467
Closed

Fix GFN-FF parallelisation issues for numerical differentiation #361

awvwgk opened this issue Oct 4, 2020 · 0 comments · Fixed by #467
Labels
easy to fix This issue has a low difficulty and little entry-barrier, great to get started with this project enhancement New feature or request

Comments

@awvwgk
Copy link
Member

awvwgk commented Oct 4, 2020

GFN-FF hessian calculation currently cannot be parallelized due to structure specific data stored inside the calculator, which requires all consumers of the calculator to make it mutable (intent(inout)).

To mitigate this issue special care has to been taken for the GFN-FF leading to code duplication in the hessian module to avoid parallelizing and breaking calculations with the GFN-FF.

Describe the solution you'd like
Remove any structure specific data from the calculator and move it to the restart data type instead. Make sure all consumers of the calculator can again use it as immutable (intent(in))

Describe alternatives you've considered
Deepcopy the GFN-FF calculator for each thread in the hessian calculation. This is not the preferred solution, since the calculator, especially for GFN-FF can become quite large.

@awvwgk awvwgk added enhancement New feature or request easy to fix This issue has a low difficulty and little entry-barrier, great to get started with this project labels Oct 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
easy to fix This issue has a low difficulty and little entry-barrier, great to get started with this project enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant