Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

github.com/golang/protobuf/jsonpb is depricated #6791

Closed
JesseLabruyere opened this issue Nov 14, 2023 · 1 comment
Closed

github.com/golang/protobuf/jsonpb is depricated #6791

JesseLabruyere opened this issue Nov 14, 2023 · 1 comment

Comments

@JesseLabruyere
Copy link

JesseLabruyere commented Nov 14, 2023

There are still some places where imports to the depricated "github.com/golang/protobuf/jsonpb" are being used.
The imports to "github.com/golang/protobuf/jsonpb" should probably be replaced with imports to "google.golang.org/protobuf/encoding/protojson". But it seems "google.golang.org/protobuf/encoding/protojson" does not contain the Marshaler and Unmarshaler structs which seems to be the only reason the old import is still in use.

The lines these imports are used:
https://github.com/grpc/grpc-go/blob/master/internal/pretty/pretty.go#L27
https://github.com/grpc/grpc-go/blob/master/xds/internal/xdsclient/bootstrap/bootstrap.go#L32

What version of gRPC are you using?

google.golang.org/grpc v1.59.0

What version of Go are you using (go version)?

go version go1.21.3 linux/amd64

What operating system (Linux, Windows, …) and version?

Ubuntu 22.04.3 LTS

What did you do?

import "google.golang.org/grpc"

What did you expect to see?

No depricated indirect requires in the go.mod file.

What did you see instead?

Deprecated module github.com/golang/protobuf.
Deprecation notice: Use the "google.golang.org/protobuf" module instead.

@dfawley
Copy link
Member

dfawley commented Nov 14, 2023

Let's use #5316 for everything related to the v1 protobuf library.

@dfawley dfawley closed this as completed Nov 14, 2023
@dfawley dfawley closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants