Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

xdsclient: store server config for LRS server in xdsresource.ClusterUpdate #6896

Closed
easwars opened this issue Dec 28, 2023 · 0 comments · Fixed by #7191
Closed

xdsclient: store server config for LRS server in xdsresource.ClusterUpdate #6896

easwars opened this issue Dec 28, 2023 · 0 comments · Fixed by #7191
Assignees
Labels
P2 Type: Feature New features or improvements in behavior

Comments

@easwars
Copy link
Contributor

easwars commented Dec 28, 2023

xdsresource.ClusterUpdate is the internal representation of a Cluster resource received from the xDS management server.

  • It is defined here:
    type ClusterUpdate struct {
  • It currently has a field for the LRS server config which is an enum that represents whether LRS is ON or OFF, and in the case where it is to be ON, the load reports are sent to the same server from which the resource was received.
  • A47 mentions a few changes to be made here:
  • A71 (xDS client fallback) adds supports for multiple server configs per xDS authority. This means that the actual server config corresponding to the server from which the Cluster resource was received needs to be communicated from the xDS transport layer to the xDS data model layer.
    • Every resource type in the data model layer implements a Decode method defined here:
      Decode(*DecodeOptions, *anypb.Any) (*DecodeResult, error)
    • A new field needs to be added to DecodeOptions to store the server config of the server from which this resource was received.
    • The Cluster resource implementation in the data model layer will use this field to populate the LRS server config.
    • The code in the cds LB policy to populate the LRS server config needs to be removed.
@easwars easwars added the Type: Feature New features or improvements in behavior label Dec 28, 2023
@easwars easwars self-assigned this Dec 28, 2023
@dfawley dfawley added the P2 label Jan 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
P2 Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants