-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
protoc-gen-go-grpc: support proto edition #7067
Comments
It would be great to add |
FYI, this should be trivial to add once protobuf-go issues a new release and you bump your dependency. Edition 2023 has no grpc-relevant features (unless you want to add some), so the following should be sufficient in your main plugin file:
|
We need to wait for protobuf-go version 1.34 to be released which should include this commit that adds support for the editions feature. |
Updated dep for protobuf to 1.34 in #7274. unblocks implementation. |
Please see the FAQ in our main README.md before submitting your issue.
Use case(s) - what problem will this feature solve?
Please add edition support in protoc-gen-go-grpc.
https://protobuf.dev/editions/overview/
protoc-gen-go@v1.33.0 works with protoc@v26.1 with
--experimental_editions
, butprotoc-gen-go-grpc can't use it
Proposed Solution
Support "edition" in protoc-gen-go-grpc.
Alternatives Considered
Keep legacy proto2/3 when using grpc.
Additional Context
The text was updated successfully, but these errors were encountered: