From 9f48a4290f57c56f2b8bd05d826d31f9c6ad55d5 Mon Sep 17 00:00:00 2001 From: Arvind Bright Date: Tue, 11 Jun 2024 15:34:16 -0700 Subject: [PATCH 1/4] github: add cache-dependency-path to setup-go --- .github/workflows/testing.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index c3bfed45f453..86fbd18d52ae 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -25,6 +25,7 @@ jobs: uses: actions/setup-go@v5 with: go-version: '1.22' + cache-dependency-path: "**/go.sum" - name: Checkout repo uses: actions/checkout@v4 @@ -84,6 +85,9 @@ jobs: uses: actions/setup-go@v5 with: go-version: ${{ matrix.goversion }} + cache-dependency-path: | + **/go.sum + **/go.mod - name: Checkout repo uses: actions/checkout@v4 From d5c9a96c1fe1e88bb9e75cc6b1b62e907c067e31 Mon Sep 17 00:00:00 2001 From: Arvind Bright Date: Tue, 11 Jun 2024 15:36:16 -0700 Subject: [PATCH 2/4] warning still exists: use a different path --- .github/workflows/testing.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 86fbd18d52ae..0c4242ca5b41 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -85,9 +85,7 @@ jobs: uses: actions/setup-go@v5 with: go-version: ${{ matrix.goversion }} - cache-dependency-path: | - **/go.sum - **/go.mod + cache-dependency-path: "**/go.sum" - name: Checkout repo uses: actions/checkout@v4 From ef10da84411ad72168b8375149934e0d10e970f0 Mon Sep 17 00:00:00 2001 From: Arvind Bright Date: Tue, 11 Jun 2024 15:37:31 -0700 Subject: [PATCH 3/4] warning still exists: use a different path --- .github/workflows/testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 0c4242ca5b41..78a8ac6473d6 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -85,7 +85,7 @@ jobs: uses: actions/setup-go@v5 with: go-version: ${{ matrix.goversion }} - cache-dependency-path: "**/go.sum" + cache-dependency-path: "**/*go.sum" - name: Checkout repo uses: actions/checkout@v4 From 737d52b0d02d95ecc8abbeebb29dd6f4b47e9b91 Mon Sep 17 00:00:00 2001 From: Arvind Bright Date: Tue, 11 Jun 2024 15:53:33 -0700 Subject: [PATCH 4/4] seems like we need the checkout step to run before setting up go - inorder to find dep refs --- .github/workflows/testing.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 78a8ac6473d6..523ec1e70044 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -20,14 +20,15 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 20 steps: + - name: Checkout repo + uses: actions/checkout@v4 + # Setup the environment. - name: Setup Go uses: actions/setup-go@v5 with: go-version: '1.22' cache-dependency-path: "**/go.sum" - - name: Checkout repo - uses: actions/checkout@v4 # Run the vet-proto checks. - name: vet-proto @@ -80,6 +81,9 @@ jobs: - name: Setup GRPC environment if: matrix.grpcenv != '' run: echo "${{ matrix.grpcenv }}" >> $GITHUB_ENV + + - name: Checkout repo + uses: actions/checkout@v4 - name: Setup Go uses: actions/setup-go@v5 @@ -87,9 +91,6 @@ jobs: go-version: ${{ matrix.goversion }} cache-dependency-path: "**/*go.sum" - - name: Checkout repo - uses: actions/checkout@v4 - # Only run vet for 'vet' runs. - name: Run vet.sh if: matrix.type == 'vet'