Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Tracking issue for SeverBuilder.addServices() being experimental #7925

Closed
voidzcy opened this issue Feb 26, 2021 · 1 comment · Fixed by #11285
Closed

Tracking issue for SeverBuilder.addServices() being experimental #7925

voidzcy opened this issue Feb 26, 2021 · 1 comment · Fixed by #11285
Labels
experimental API Issue tracks stabilizing an experimental API
Milestone
1.66

Comments

@voidzcy
Copy link
Contributor

voidzcy commented Feb 26, 2021

No description provided.

@voidzcy voidzcy added the experimental API Issue tracks stabilizing an experimental API label Feb 26, 2021
@voidzcy voidzcy added this to the Unscheduled milestone Feb 26, 2021
@voidzcy voidzcy changed the title Tracking issue for SeverBuilder.addServices(List<BindableServices>) Tracking issue for SeverBuilder.addServices(List<BindableService>) Feb 26, 2021
@voidzcy voidzcy changed the title Tracking issue for SeverBuilder.addServices(List<BindableService>) Tracking issue for SeverBuilder.addServices() Feb 26, 2021
@voidzcy voidzcy changed the title Tracking issue for SeverBuilder.addServices() Tracking issue for SeverBuilder.addServices() being experimental Feb 26, 2021
@larry-safran
Copy link
Contributor

Change javadoc to say that it is the same as iterating over the list calling addService.
Update addService javadoc to say that in case of duplicate names the last one is what is used (reflects current behavior).

@temawi temawi mentioned this issue Jun 13, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
@ejona86 ejona86 modified the milestones: Unscheduled, 1.66 Sep 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
experimental API Issue tracks stabilizing an experimental API
Projects
None yet
Milestone
1.66
Development

Successfully merging a pull request may close this issue.

api: Stabilize ServerBuilder.AddServices() temawi/grpc-java
3 participants
@voidzcy @ejona86 @larry-safran