From 657a8295714d3d03d6c98a05bd0c028546a105ce Mon Sep 17 00:00:00 2001 From: Terry Wilson Date: Thu, 13 Jun 2024 10:17:08 -0700 Subject: [PATCH 1/2] api: Stabilize ServerBuilder.AddServices() --- api/src/main/java/io/grpc/ServerBuilder.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/api/src/main/java/io/grpc/ServerBuilder.java b/api/src/main/java/io/grpc/ServerBuilder.java index c2ad566f90f..7baee192d1f 100644 --- a/api/src/main/java/io/grpc/ServerBuilder.java +++ b/api/src/main/java/io/grpc/ServerBuilder.java @@ -114,13 +114,15 @@ public T callExecutor(ServerCallExecutorSupplier executorSupplier) { public abstract T addService(BindableService bindableService); /** - * Adds a list of service implementations to the handler registry together. + * Adds a list of service implementations to the handler registry together. This exists for + * convenience - equivalent to repeatedly calling addService() with diffferent services. + * If multiple services on the list use the same name, only the last one on the list will + * be added. * * @param services the list of ServerServiceDefinition objects * @return this * @since 1.37.0 */ - @ExperimentalApi("https://github.com/grpc/grpc-java/issues/7925") public final T addServices(List services) { checkNotNull(services, "services"); for (ServerServiceDefinition service : services) { From 8b116c03811ae4ad163962c5eb92b40b207b84cf Mon Sep 17 00:00:00 2001 From: Terry Wilson Date: Thu, 13 Jun 2024 10:19:56 -0700 Subject: [PATCH 2/2] Fix typo --- api/src/main/java/io/grpc/ServerBuilder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/src/main/java/io/grpc/ServerBuilder.java b/api/src/main/java/io/grpc/ServerBuilder.java index 7baee192d1f..cd1cddbb93f 100644 --- a/api/src/main/java/io/grpc/ServerBuilder.java +++ b/api/src/main/java/io/grpc/ServerBuilder.java @@ -115,7 +115,7 @@ public T callExecutor(ServerCallExecutorSupplier executorSupplier) { /** * Adds a list of service implementations to the handler registry together. This exists for - * convenience - equivalent to repeatedly calling addService() with diffferent services. + * convenience - equivalent to repeatedly calling addService() with different services. * If multiple services on the list use the same name, only the last one on the list will * be added. *