Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add option to suppress permissive types #2840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option to suppress permissive types #2840

wants to merge 1 commit into from

Conversation

jdforsythe
Copy link
Contributor

@jdforsythe jdforsythe commented Oct 10, 2024 •
edited
Loading

Fixes #2839

Allows suppressing the permissive types with --suppressPermissiveTypes=true

In combination with --outputTemplate="%s", replaces the permissive types with the restrictive types using the default message name (without __Output).

@murgatroid99
Copy link
Member

This also impacts the output of the generateService* functions, because they currently use both the permissive and restrictive types. I think it might be enough to modify useNameFmter with a branch for this flag, but I'm not 100% sure.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jdforsythe @murgatroid99 @kokoro-team