Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Primary key of Achiever #42

Open
KostyaChoporov opened this issue Apr 16, 2019 · 0 comments
Open

Primary key of Achiever #42

KostyaChoporov opened this issue Apr 16, 2019 · 0 comments

Comments

@KostyaChoporov
Copy link

KostyaChoporov commented Apr 16, 2019

As I see - now it forced to use id attribute in getOrCreateProgressForAchiever method.

Why just not use getKey() instead of id here:
https://github.com/gstt/laravel-achievements/blob/master/src/Achievement.php#L159

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant