Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The reward is not clip in the codes #14

Open
xqlin98 opened this issue Nov 9, 2021 · 0 comments
Open

The reward is not clip in the codes #14

xqlin98 opened this issue Nov 9, 2021 · 0 comments

Comments

@xqlin98
Copy link

xqlin98 commented Nov 9, 2021

if clip: np.sign(reward)
this operation can not change the value of reward, and it should be
if clip: reward = np.sign(reward)

Maybe it's the problem of the NumPy version. In my numpy environment, sign didn't support in-place update.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xqlin98