Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Validate more interactive features (completion, etc) #7

Closed
nrbgt opened this issue Feb 19, 2021 · 3 comments · Fixed by #8
Closed

Validate more interactive features (completion, etc) #7

nrbgt opened this issue Feb 19, 2021 · 3 comments · Fixed by #8
Labels
bug Something isn't working

Comments

@nrbgt
Copy link
Contributor

nrbgt commented Feb 19, 2021

Users report hard-to-read text in completions. Do a pass through all the LSP/JKM features to verify contrast.

@nrbgt nrbgt added the bug Something isn't working label Feb 19, 2021
@nrbgt
Copy link
Contributor Author

nrbgt commented Feb 19, 2021

Screenshot from 2021-02-19 11-30-23

@sanbales
Copy link

Wonder if you could programmatically run through the possible combinations of foreground and background colors and make sure the contrast is >4.5.

https://stackoverflow.com/questions/9733288/how-to-programmatically-calculate-the-contrast-ratio-between-two-colors

@nrbgt
Copy link
Contributor Author

nrbgt commented Feb 19, 2021

PRs welcome!

if imma do that, it's going to be like pydata/pydata-sphinx-theme#294 and fix lab core first.

@nrbgt nrbgt closed this as completed in #8 Feb 19, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants